Skip to content

Use default GOMAXPROCS behavior#621

Merged
fzdarsky merged 1 commit into
openshift:mainfrom
derekwaynecarr:use-default-gomaxprocs
Mar 7, 2022
Merged

Use default GOMAXPROCS behavior#621
fzdarsky merged 1 commit into
openshift:mainfrom
derekwaynecarr:use-default-gomaxprocs

Conversation

@derekwaynecarr

@derekwaynecarr derekwaynecarr commented Mar 7, 2022

Copy link
Copy Markdown
Member

Stop setting GOMAXPROCS as more recent versions of Golang already defaults to NumCPU.
Aligns with OpenShift Standalone.

see: https://pkg.go.dev/runtime#GOMAXPROCS

@openshift-ci openshift-ci Bot requested review from cooktheryan and sallyom March 7, 2022 16:41
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 7, 2022
@openshift-ci

openshift-ci Bot commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

Hi @derekwaynecarr. Thanks for your PR.

I'm waiting for a redhat-et member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fzdarsky

fzdarsky commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2022
@fzdarsky

fzdarsky commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 7, 2022
@openshift-ci

openshift-ci Bot commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

@derekwaynecarr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-apps 36a84a5 link false /test e2e-openshift-conformance-sig-apps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mangelajo
mangelajo reviewed Mar 7, 2022
View reviewed changes

@mangelajo mangelajo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzdarsky, mangelajo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fzdarsky fzdarsky merged commit 05a57a5 into openshift:main Mar 7, 2022
@mangelajo mangelajo mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cooktheryan cooktheryan Awaiting requested review from cooktheryan

@sallyom sallyom Awaiting requested review from sallyom

1 more reviewer

@mangelajo mangelajo mangelajo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mangelajo mangelajo

@fzdarsky fzdarsky

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@derekwaynecarr @fzdarsky @mangelajo